Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a failure instead of an error if no pinned images are found #1197

Merged

Conversation

komish
Copy link
Contributor

@komish komish commented Sep 12, 2024

If no pinned images were found, we would throw an error for the CertifiedImages check, which isn't technically valid (because we didn't fail to run). This PR converts that into a failure instead. We would get the error in trying to query Pyxis for images with the provided digests. We're returning the error (not Pyxis), but we still want to catch it when returned and make sure it translates to a failure result and not a check execution error.

It also seems like this check had an older style "optional" configuration, which was to return true regardless of things that would cause this check to fail. I've now made this check's return value accurate to its execution, and allow for the "optional" tag enforce that it's non-blocking.

Finally, I've updated tests which asserted that the things would pass according to the older style of "optional". They would now fail, so the checks needed to be updated accordingly.

This check remains non-blocking for certification.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
@dcibot
Copy link

dcibot commented Sep 12, 2024

@komish
Copy link
Contributor Author

komish commented Sep 13, 2024

/test 4.17-e2e

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2024
Copy link
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet,komish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bcrochet bcrochet merged commit 755831a into redhat-openshift-ecosystem:main Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants